feat: adds David’s shinobi’s objects #650
Merged
VicenteVigueras merged 3 commits intocode-differently:mainfrom May 16, 2025
Merged
feat: adds David’s shinobi’s objects #650VicenteVigueras merged 3 commits intocode-differently:mainfrom
VicenteVigueras merged 3 commits intocode-differently:mainfrom
Conversation
VicenteVigueras
approved these changes
May 16, 2025
Contributor
VicenteVigueras
left a comment
VicenteVigueras
left a comment
There was a problem hiding this comment.
There are definitely some areas for improvement. 1) The folder for your object was in the wrong location, 2) There was an attempt to instantiate an enum using the new keyword (which isn't correct), and 3) one of the tests was failing to compile.
However, the code looks good overall and the basic requirements were met, so I'll proceed with the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.